-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:support non-properties-diff #4533
feature:support non-properties-diff #4533
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA. |
I record a video for this feature, and please criticize and correct me, thank you very much! QQ.20220823234052.mp4 |
@SunnyBoy-WYH |
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
=========================================
Coverage 53.41% 53.41%
Complexity 2708 2708
=========================================
Files 492 492
Lines 15390 15390
Branches 1596 1596
=========================================
Hits 8220 8220
Misses 6611 6611
Partials 559 559 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
</div> | ||
<div class="radio-inline"> | ||
<label > | ||
<input type="radio" name="tableDiff" ng-click="isTableDiff = false" ng-checked="isTableDiff == false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be simplified to?
ng-checked="!isTableDiff"
apollo-portal/src/main/resources/static/scripts/controller/config/DiffConfigController.js
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
feature: support diff config for non-properties type files.
Which issue(s) this PR fixes:
Fixes #
link:#4315
Brief changelog