-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic type check for Item value #4542
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA |
Co-authored-by: mghio <43461943+mghio@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a pull request that added JSON check feature #4519. I think this pull request could provide a general type check by combining that PR's codes, e.g. enhance the check
function that only validates JSON with the ability to check other types.
There are some unit test failures, please also help to fix them. |
I already view #4519, I think it is a good idea to enhance |
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
if in this way, don't forget openapi module. openapi may also need to be compatible with type. |
This is a good point. |
.../src/main/java/com/ctrip/framework/apollo/openapi/client/service/AbstractOpenApiService.java
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/directive/item-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/directive/item-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/directive/item-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/directive/item-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/directive/item-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/directive/item-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/directive/item-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/views/component/namespace-panel-master-tab.html
Outdated
Show resolved
Hide resolved
…-modal-directive.js Co-authored-by: Jason Song <nobodyiam@gmail.com>
…-modal-directive.js Co-authored-by: Jason Song <nobodyiam@gmail.com>
…-modal-directive.js Co-authored-by: Jason Song <nobodyiam@gmail.com>
…-modal-directive.js Co-authored-by: Jason Song <nobodyiam@gmail.com>
…-modal-directive.js Co-authored-by: Jason Song <nobodyiam@gmail.com>
This reverts commit 6b983a0
2. move openapi check to service side.
...rc/main/java/com/ctrip/framework/apollo/openapi/server/service/ServerItemOpenApiService.java
Outdated
Show resolved
Hide resolved
...service/src/main/java/com/ctrip/framework/apollo/adminservice/controller/ItemController.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4542 +/- ##
============================================
+ Coverage 53.33% 53.45% +0.11%
- Complexity 2712 2724 +12
============================================
Files 495 495
Lines 15440 15460 +20
Branches 1599 1599
============================================
+ Hits 8235 8264 +29
+ Misses 6646 6631 -15
- Partials 559 565 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Add basic type check for Item value
Which issue(s) this PR fixes:
Fixes #1517
Brief changelog
Add basic type check for Item value
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.