Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a json serialization problem during LDAP integration #4556

Merged
merged 59 commits into from
Sep 14, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Sep 8, 2022

What's the purpose of this PR

Fix a json serialization problem during LDAP integration

Which issue(s) this PR fixes:

Fixes #4536

klboke and others added 30 commits May 16, 2019 11:07
@codecov-commenter
Copy link

Codecov Report

Merging #4556 (3db727b) into master (85bc77d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4556      +/-   ##
============================================
+ Coverage     53.37%   53.40%   +0.02%     
- Complexity     2705     2707       +2     
============================================
  Files           492      492              
  Lines         15390    15390              
  Branches       1596     1596              
============================================
+ Hits           8215     8219       +4     
+ Misses         6615     6611       -4     
  Partials        560      560              
Impacted Files Coverage Δ
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

apollo-portal/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 0b2b05a into apolloconfig:master Sep 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
@klboke klboke deleted the spring-session-ldap branch March 21, 2023 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after apollo spring session upgrade with config class SpringSessionConfig, LDAP login error
3 participants