Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the exception occurred when publish/rollback namespaces with grayrelease #4564

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

fix the exception occurred when publish/rollback namespaces with grayrelease

Which issue(s) this PR fixes:

Fixes #4563

Brief changelog

  • revert the OPERATION_CONTEXT_TYPE_REFERENCE to new TypeToken<Map<String, Object>>() { }.getType()

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #4564 (c43bd70) into master (b344d54) will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #4564      +/-   ##
============================================
+ Coverage     53.28%   53.31%   +0.03%     
  Complexity     2711     2711              
============================================
  Files           495      495              
  Lines         15438    15437       -1     
  Branches       1599     1599              
============================================
+ Hits           8226     8231       +5     
+ Misses         6652     6646       -6     
  Partials        560      560              
Impacted Files Coverage Δ
...p/framework/apollo/biz/service/ReleaseService.java 71.87% <33.33%> (+0.27%) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 78.44% <0.00%> (+1.19%) ⬆️
...ework/apollo/internals/RemoteConfigRepository.java 87.73% <0.00%> (+2.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mghio
mghio previously approved these changes Sep 11, 2022
Copy link
Contributor

@mghio mghio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nobodyiam nobodyiam merged commit f541ff2 into apolloconfig:master Sep 12, 2022
@nobodyiam nobodyiam deleted the fix-4563 branch September 12, 2022 06:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception occurred when publish/rollback namespaces with gray release
3 participants