Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apollo checks the yaml format interface Response Code = 500 #4567

Merged
merged 59 commits into from
Sep 16, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Sep 14, 2022

What's the purpose of this PR

Fix Apollo checks the yaml format interface Response Code = 500

Which issue(s) this PR fixes:

#4566

klboke and others added 30 commits May 16, 2019 11:07
@codecov-commenter
Copy link

Codecov Report

Merging #4567 (35ab455) into master (0b2b05a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4567      +/-   ##
============================================
+ Coverage     53.29%   53.30%   +0.01%     
+ Complexity     2711     2710       -1     
============================================
  Files           495      495              
  Lines         15437    15440       +3     
  Branches       1599     1599              
============================================
+ Hits           8227     8231       +4     
  Misses         6650     6650              
+ Partials        560      559       -1     
Impacted Files Coverage Δ
...ework/apollo/portal/controller/ItemController.java 17.77% <100.00%> (+2.83%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0.00%> (-8.34%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...ework/apollo/internals/RemoteConfigRepository.java 87.73% <0.00%> (+2.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 526a935 into apolloconfig:master Sep 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
@klboke klboke deleted the syntax-check branch March 21, 2023 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants