Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move apollo-core, apollo-client, apollo-mockserver, apollo-openapi and apollo-client-config-data to apollo-java repo #4594

Merged

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Move apollo-core, apollo-client, apollo-mockserver, apollo-openapi and apollo-client-config-data to apollo-java repo, see #4427

Brief changelog

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #4594 (58e40b8) into master (f7e7100) will decrease coverage by 7.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4594      +/-   ##
============================================
- Coverage     53.40%   46.33%   -7.08%     
+ Complexity     2721     1560    -1161     
============================================
  Files           495      331     -164     
  Lines         15460    10356    -5104     
  Branches       1599     1042     -557     
============================================
- Hits           8257     4798    -3459     
+ Misses         6636     5261    -1375     
+ Partials        567      297     -270     
Impacted Files Coverage Δ
...framework/apollo/openapi/dto/OpenNamespaceDTO.java
...ork/apollo/openapi/client/ApolloOpenApiClient.java
...apollo/openapi/dto/NamespaceGrayDelReleaseDTO.java
...mework/apollo/openapi/dto/NamespaceReleaseDTO.java
...ctrip/framework/apollo/openapi/utils/UrlUtils.java
...om/ctrip/framework/apollo/openapi/dto/BaseDTO.java
...trip/framework/apollo/openapi/dto/OpenPageDTO.java
.../openapi/client/service/ClusterOpenApiService.java
...p/framework/apollo/openapi/dto/OpenClusterDTO.java
...ework/apollo/openapi/dto/OpenNamespaceLockDTO.java
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…d apollo-client-config-data to apollo-java repo
Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mghio mghio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 301d66d into apolloconfig:master Oct 4, 2022
@nobodyiam nobodyiam deleted the move-client-to-apollo-java branch October 4, 2022 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants