Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of deleting blank items appear at the end#4654 #4662

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

wanggang19
Copy link
Contributor

@wanggang19 wanggang19 commented Nov 26, 2022

What's the purpose of this PR

Fix the problem of deleting blank items appear at the end.

Which issue(s) this PR fixes:

Fixes #4654

Brief changelog

1.delete blank item then it'll appear at the end
image
image

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Nov 26, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #4662 (a0365ac) into master (00d968a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4662      +/-   ##
============================================
- Coverage     47.21%   47.12%   -0.09%     
+ Complexity     1649     1648       -1     
============================================
  Files           347      347              
  Lines         10643    10643              
  Branches       1057     1057              
============================================
- Hits           5025     5016       -9     
- Misses         5314     5323       +9     
  Partials        304      304              
Impacted Files Coverage Δ
...portal/component/txtresolver/PropertyResolver.java 89.77% <0.00%> (ø)
...oServiceRegistryDeregisterApplicationListener.java 30.00% <0.00%> (-45.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wanggang19
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@wanggang19
Copy link
Contributor Author

@nobodyiam I recommit the change, please help me review the code again.

@wanggang19
Copy link
Contributor Author

@lepdou thanks

@nobodyiam
Copy link
Member

The code change looks good to me. Would you please help to update the CHANGES.md?

@wanggang19
Copy link
Contributor Author

The code change looks good to me. Would you please help to update the CHANGES.md?

create request to update CHANGES.md?

@Anilople Anilople mentioned this pull request Nov 28, 2022
5 tasks
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 22585a8 into apolloconfig:master Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文本无法删除尾部的空行
2 participants