-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of deleting blank items appear at the end#4654 #4662
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## master #4662 +/- ##
============================================
- Coverage 47.21% 47.12% -0.09%
+ Complexity 1649 1648 -1
============================================
Files 347 347
Lines 10643 10643
Branches 1057 1057
============================================
- Hits 5025 5016 -9
- Misses 5314 5323 +9
Partials 304 304
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I have read the CLA Document and I hereby sign the CLA |
@nobodyiam I recommit the change, please help me review the code again. |
@lepdou thanks |
The code change looks good to me. Would you please help to update the CHANGES.md? |
create request to update CHANGES.md? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Fix the problem of deleting blank items appear at the end.
Which issue(s) this PR fixes:
Fixes #4654
Brief changelog
1.delete blank item then it'll appear at the end
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.