Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal-UI adds serverconfig configuration management of ApolloConfigDB #4680

Merged
merged 70 commits into from
Dec 15, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Dec 14, 2022

What's the purpose of this PR

Portal-UI adds serverconfig configuration management of ApolloConfigDB

Some functional features

  • Switch PortalDB, ConfigDB configuration management through tabs
  • When editing and adding configurations, it is forbidden to switch tabs
  • ConfigDB's configuration management supports switching environments

image

image

klboke and others added 30 commits May 16, 2019 11:07
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #4680 (99fc20b) into master (7df79bf) will increase coverage by 0.08%.
The diff coverage is 70.21%.

@@             Coverage Diff              @@
##             master    #4680      +/-   ##
============================================
+ Coverage     47.12%   47.21%   +0.08%     
- Complexity     1646     1656      +10     
============================================
  Files           347      349       +2     
  Lines         10660    10691      +31     
  Branches       1060     1062       +2     
============================================
+ Hits           5024     5048      +24     
- Misses         5331     5336       +5     
- Partials        305      307       +2     
Impacted Files Coverage Δ
...p/framework/apollo/portal/api/AdminServiceAPI.java 13.19% <25.00%> (+0.24%) ⬆️
...ork/apollo/portal/service/ServerConfigService.java 50.00% <50.00%> (-10.00%) ⬇️
...ollo/portal/controller/ServerConfigController.java 85.71% <80.00%> (+15.12%) ⬆️
...mework/apollo/biz/service/ServerConfigService.java 93.33% <93.33%> (ø)
...dminservice/controller/ServerConfigController.java 100.00% <100.00%> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 84.70% <0.00%> (-1.18%) ⬇️
...trip/framework/apollo/biz/entity/ServerConfig.java 92.85% <0.00%> (+21.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nobodyiam nobodyiam merged commit d262471 into apolloconfig:master Dec 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
@klboke klboke deleted the config branch March 21, 2023 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants