-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ConfigsExportServiceTest support windows #4765
Make ConfigsExportServiceTest support windows #4765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also change line 174?
FileInputStream fileInputStream = new FileInputStream("/tmp/apollo.zip");
66b85f4
to
2d983d3
Compare
@nobodyiam My fault, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2d983d3
to
362a5b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
============================================
+ Coverage 47.27% 47.35% +0.08%
- Complexity 1655 1657 +2
============================================
Files 346 346
Lines 10662 10662
Branches 1058 1058
============================================
+ Hits 5040 5049 +9
+ Misses 5316 5307 -9
Partials 306 306
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What's the purpose of this PR
Make ConfigsExportServiceTest support windows.