Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused testing log config #4789

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

shoothzj
Copy link
Member

Brief changelog

Remove unused testing log config

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #4789 (06baa3c) into master (a6c7aa6) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4789      +/-   ##
============================================
- Coverage     47.25%   47.21%   -0.04%     
+ Complexity     1660     1658       -2     
============================================
  Files           346      346              
  Lines         10683    10683              
  Branches       1063     1063              
============================================
- Hits           5048     5044       -4     
- Misses         5327     5331       +4     
  Partials        308      308              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam
Copy link
Member

I think the apollo-portal/src/test/resources/application.yml also needs some fix.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 670cc0e into apolloconfig:master Mar 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
@shoothzj shoothzj deleted the remove-test branch March 14, 2023 23:54
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants