Refining the configs interface documentation #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4804 +/- ##
============================================
- Coverage 47.34% 47.33% -0.01%
+ Complexity 1663 1662 -1
============================================
Files 346 346
Lines 10684 10684
Branches 1064 1064
============================================
- Hits 5058 5057 -1
Misses 5319 5319
- Partials 307 308 +1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Anilople
previously approved these changes
Mar 17, 2023
nobodyiam
reviewed
Mar 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Refining the configs interface documentation
Motivation：
I have noticed that many third-party Apollo client implementations do not pass the messages parameter, which can cause delays in obtaining configurations in a multi-instance Apollo-configservice environment with memory caching enabled.