Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the code related to ReleaseMessage #4822

Merged
merged 93 commits into from
Apr 1, 2023

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Mar 28, 2023

What's the purpose of this PR

Refactor the code related to ReleaseMessage.

motivation

  • Unify the generation method of ReleaseMessage and watchedKey.
  • Abstract the parsing method of ReleaseMessage and unify the invocation.

klboke and others added 30 commits May 16, 2019 11:07
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #4822 (1c47cd6) into master (a86ed25) will increase coverage by 0.00%.
The diff coverage is 78.94%.

❗ Current head 1c47cd6 differs from pull request most recent head d1cf7ad. Consider uploading reports for the commit d1cf7ad to get more accurate results

@@            Coverage Diff            @@
##             master    #4822   +/-   ##
=========================================
  Coverage     48.15%   48.16%           
  Complexity     1719     1719           
=========================================
  Files           346      346           
  Lines         10777    10772    -5     
  Branches       1075     1076    +1     
=========================================
- Hits           5190     5188    -2     
+ Misses         5265     5262    -3     
  Partials        322      322           
Impacted Files Coverage Δ
...lo/biz/grayReleaseRule/GrayReleaseRulesHolder.java 72.58% <50.00%> (+0.13%) ⬆️
...nfigservice/controller/NotificationController.java 91.22% <50.00%> (+1.22%) ⬆️
...igservice/controller/NotificationControllerV2.java 86.61% <50.00%> (+0.41%) ⬆️
...service/service/config/ConfigServiceWithCache.java 75.75% <50.00%> (-0.72%) ⬇️
...k/apollo/biz/utils/ReleaseMessageKeyGenerator.java 90.90% <100.00%> (+24.24%) ⬆️
...ework/apollo/configservice/util/WatchKeysUtil.java 93.61% <100.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@klboke klboke requested a review from nobodyiam March 28, 2023 10:15
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 11303c7 into apolloconfig:master Apr 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
@klboke klboke deleted the kl-watchKey branch April 4, 2023 02:41
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants