Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clean code] Remove unused imports #4825

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

shoothzj
Copy link
Member

What's the purpose of this PR

Remove unused imports

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #4825 (817defe) into master (4acee42) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4825   +/-   ##
=========================================
  Coverage     48.15%   48.15%           
  Complexity     1719     1719           
=========================================
  Files           346      346           
  Lines         10777    10777           
  Branches       1075     1075           
=========================================
  Hits           5190     5190           
  Misses         5265     5265           
  Partials        322      322           
Impacted Files Coverage Δ
...p/framework/apollo/biz/entity/ServiceRegistry.java 67.85% <ø> (ø)
...ollo/biz/registry/DatabaseServiceRegistryImpl.java 100.00% <ø> (ø)
...llo/configservice/controller/ConfigController.java 97.46% <ø> (ø)
...configservice/controller/ConfigFileController.java 84.40% <ø> (ø)
...mework/apollo/openapi/service/ConsumerService.java 58.46% <ø> (ø)
...llo/portal/spi/defaultimpl/DefaultUserService.java 92.30% <ø> (ø)
...work/apollo/portal/spi/oidc/OidcLogoutHandler.java 0.00% <ø> (ø)
...framework/apollo/portal/util/NamespaceBOUtils.java 37.50% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit a86ed25 into apolloconfig:master Mar 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
@shoothzj shoothzj deleted the remove-imports branch March 31, 2023 01:27
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants