refactor(apollo logging): Simplify the default log path to /opt/logs

[klboke]

What's the purpose of this PR

refactor(apollo logging): Simplify the default log path to /opt/logs

motivation

The default log path for all Apollo services is prefixed with 100003172, which seems to have no additional purpose but hinders quick locating of log files. It's time to remove it.

[codecov]

Codecov Report

Merging #4833 (0892fa0) into master (3a6ff67) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4833      +/-   ##
============================================
+ Coverage     48.38%   48.40%   +0.01%     
- Complexity     1722     1724       +2     
============================================
  Files           346      346              
  Lines         10827    10827              
  Branches       1078     1078              
============================================
+ Hits           5239     5241       +2     
+ Misses         5266     5264       -2     
  Partials        322      322              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[nobodyiam]

There is an issue that the gc.log would conflict if they are running in one machine.

apollo/apollo-configservice/src/main/scripts/startup.sh

Lines 95 to 110 in 2800a00

	if [[ "$javaexe" ]]; then
	version=$("$javaexe" -version 2>&1 | awk -F '"' '/version/ {print $2}')
	version=$(echo "$version" | awk -F. '{printf("%03d%03d",$1,$2);}')
	# now version is of format 009003 (9.3.x)
	if [ $version -ge 011000 ]; then
	JAVA_OPTS="$JAVA_OPTS -Xlog:gc*:$LOG_DIR/gc.log:time,level,tags -Xlog:safepoint -Xlog:gc+heap=trace"
	elif [ $version -ge 010000 ]; then
	JAVA_OPTS="$JAVA_OPTS -Xlog:gc*:$LOG_DIR/gc.log:time,level,tags -Xlog:safepoint -Xlog:gc+heap=trace"
	elif [ $version -ge 009000 ]; then
	JAVA_OPTS="$JAVA_OPTS -Xlog:gc*:$LOG_DIR/gc.log:time,level,tags -Xlog:safepoint -Xlog:gc+heap=trace"
	else
	JAVA_OPTS="$JAVA_OPTS -XX:+UseParNewGC"
	JAVA_OPTS="$JAVA_OPTS -Xloggc:$LOG_DIR/gc.log -XX:+PrintGCDetails"
	JAVA_OPTS="$JAVA_OPTS -XX:+UseConcMarkSweepGC -XX:+UseCMSCompactAtFullCollection -XX:+UseCMSInitiatingOccupancyOnly -XX:CMSInitiatingOccupancyFraction=60 -XX:+CMSClassUnloadingEnabled -XX:+CMSParallelRemarkEnabled -XX:CMSFullGCsBeforeCompaction=9 -XX:+CMSClassUnloadingEnabled -XX:+PrintGCDateStamps -XX:+PrintGCApplicationConcurrentTime -XX:+PrintHeapAtGC -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5 -XX:GCLogFileSize=5M"
	fi
	fi

[shoothzj]

As I think, we can use a more reasonable name, like /opt/apollo/logs, not magic number

[klboke]

@nobodyiam

There is an issue that the gc.log would conflict if they are running in one machine.

Adding prefix of ServiceName to gc.log path

[nobodyiam]

LGTM