Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the slf4j-api version define #4838

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

shoothzj
Copy link
Member

@shoothzj shoothzj commented Apr 6, 2023

What's the purpose of this PR

Remove the old slf4j-api version, since SpringBoot already has it, and higher than we define.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 3a6ff67 into apolloconfig:master Apr 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
@shoothzj shoothzj deleted the remove-slf4j branch April 7, 2023 01:31
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants