-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi-Database Support][h2] Support run on h2 #4851
Conversation
Hello, I am a serverless review bot on flows.network. Here are my reviews of code commits in this PR. Commit 1This patch adds support for the h2 database to Apollo. It does this by adding an h2 initialization script, an annotation for running the script and a datasource field. The h2 initialization script makes changes to the ServerConfig table by adding a new row. There are no apparent potential problems with this patch. |
1bf1e97
to
2a483be
Compare
review again |
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
Codecov Report
@@ Coverage Diff @@
## master #4851 +/- ##
============================================
+ Coverage 48.36% 48.46% +0.09%
- Complexity 1722 1725 +3
============================================
Files 346 346
Lines 10827 10835 +8
Branches 1078 1080 +2
============================================
+ Hits 5237 5251 +14
+ Misses 5268 5260 -8
- Partials 322 324 +2
|
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/BizDBPropertySource.java
Outdated
Show resolved
Hide resolved
...o-portal/src/main/java/com/ctrip/framework/apollo/portal/service/PortalDBPropertySource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Added support for h2 init sql to ApolloConfig. Verified the following functionalities: adding/disabling/enabling users, adding/deleting namespaces, publishing configurations, and adding applications.
Brief changelog
Add h2 init sql, only effective when h2
How to use it
apollo-config run args
apollo-portal run args
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.