Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:deployment-architecture #4876

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

jiaoningbo
Copy link
Contributor

@jiaoningbo jiaoningbo commented May 16, 2023

What's the purpose of this PR

Fix the inconsistency between schematic diagram and description in official documents

Which issue(s) this PR fixes:

Discussions:#4874

Brief changelog

Only documentation related to deployment was modified

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Fix the inconsistency between schematic diagram and description in official documents

Discussions:[apolloconfig#4874](apolloconfig#4874)
@github-actions
Copy link

github-actions bot commented May 16, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jiaoningbo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #4876 (8fa9236) into master (37422de) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4876      +/-   ##
============================================
- Coverage     48.46%   48.36%   -0.11%     
+ Complexity     1725     1722       -3     
============================================
  Files           346      346              
  Lines         10835    10835              
  Branches       1080     1080              
============================================
- Hits           5251     5240      -11     
- Misses         5260     5274      +14     
+ Partials        324      321       -3     

see 7 files with indirect coverage changes

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit a1bf9eb into apolloconfig:master May 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants