docs: polish secret key implementation description #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4897 +/- ##
============================================
- Coverage 48.47% 48.43% -0.05%
Complexity 1726 1726
============================================
Files 346 346
Lines 10836 10836
Branches 1080 1080
============================================
- Hits 5253 5248 -5
- Misses 5259 5265 +6
+ Partials 324 323 -1 |
|
Would you please also help to update the en doc? |
nisiyong
force-pushed
the
nisiyong-patch-1
branch
from
52c2657
to
6dd631b
Compare
Sure, Please take a look. |
nobodyiam
reviewed
Jun 7, 2023
nobodyiam
reviewed
Jun 7, 2023
nobodyiam
reviewed
Jun 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
polish secret key implementation description
Which issue(s) this PR fixes:
Fixes #4856