Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade docsify version to fix potential xss vulnerability #4939

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

upgrade docsify version to fix potential xss vulnerability, see docsifyjs/docsify#2093

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #4939 (340e04a) into master (d6bf360) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4939      +/-   ##
============================================
- Coverage     48.44%   48.41%   -0.04%     
+ Complexity     1727     1725       -2     
============================================
  Files           346      346              
  Lines         10836    10836              
  Branches       1080     1080              
============================================
- Hits           5250     5246       -4     
- Misses         5263     5265       +2     
- Partials        323      325       +2     

see 2 files with indirect coverage changes

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It works well on my machine.

@nobodyiam nobodyiam merged commit 99b76dc into apolloconfig:master Jul 26, 2023
7 of 8 checks passed
@nobodyiam nobodyiam deleted the upgrade-docsify-version branch July 26, 2023 01:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants