Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config import on windows #5088

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Feb 2, 2024

What's the purpose of this PR

file separator on windows is "\"

image
image

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c90c930) 50.30% compared to head (b199d82) 50.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5088      +/-   ##
============================================
+ Coverage     50.30%   50.36%   +0.05%     
  Complexity     2010     2010              
============================================
  Files           387      387              
  Lines         12213    12213              
  Branches       1207     1207              
============================================
+ Hits           6144     6151       +7     
+ Misses         5706     5697       -9     
- Partials        363      365       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 2, 2024
@vdiskg vdiskg changed the title fix testNamespaceExportImport on windows fix config import on windows Feb 2, 2024
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2024
@nobodyiam nobodyiam merged commit a73d032 into apolloconfig:master Feb 3, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants