Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync apollo portal server config to apollo quick start server #5134

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Apr 27, 2024

What's the purpose of this PR

The apollo quick start uses a standalone application.yml config file under apollo-assembly module which lacks some configurations. This pr aims to sync these missing configurations.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Summary by CodeRabbit

  • New Features
    • Added a feature to synchronize configurations between Apollo portal and quick start servers.
    • Enhanced server settings including compression, Tomcat configurations, and secure session cookie settings.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 27, 2024
Copy link
Contributor

coderabbitai bot commented Apr 27, 2024

Walkthrough

The latest update for Apollo, version 2.3.0, introduces a pivotal feature that synchronizes configurations between the Apollo portal and quick start servers. Additionally, enhancements in server compression, Tomcat settings, and session cookie configurations are included to improve performance and security.

Changes

File Path Change Summary
CHANGES.md Added feature to sync Apollo portal server config with Apollo quick start server.
apollo-assembly/src/.../application.yml Added server compression, Tomcat settings, and servlet session cookie configurations.

Poem

🌟🐇
In the world of code, where changes abound,
A rabbit hopped in, with leaps and bounds.
Syncing servers with a magical flair,
Cookies and compressions added with care.
Oh, how the servers hum and sing,
Thanks to the updates the changes bring!
🌟🐇


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ed416a1 and 4a9272a.
Files selected for processing (2)
  • CHANGES.md (1 hunks)
  • apollo-assembly/src/main/resources/application.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • apollo-assembly/src/main/resources/application.yml
Additional Context Used
LanguageTool (2)
CHANGES.md (2)

Near line 8: Possible spelling mistake found.
Context: ...--------- * [Fix circular references on LdapAutoConfiguration](https://github.com/apolloconfig/apollo...


Near line 10: Possible spelling mistake found.
Context: ...at the length of private namespaces are mis-calculated](https://github.com/apolloconfig/apollo...

Additional comments not posted (1)
CHANGES.md (1)

13-13: Ensure the description of the change is detailed and reflects the scope of the changes made in the pull request.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (2)
CHANGES.md (2)

Line range hint 1-1: Add a blank line after the "Release Notes." heading for better readability.

  Release Notes.
+

Line range hint 8-8: Add blank lines around the list of changes to improve readability and adhere to Markdown best practices.

  Apollo 2.3.0
+
  ------------------

@@ -10,7 +10,7 @@ Apollo 2.3.0
* [Fix the issue that the length of private namespaces are mis-calculated](https://github.com/apolloconfig/apollo/pull/5078)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the spelling of "mis-calculated" to "miscalculated".

- mis-calculated
+ miscalculated

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* [Fix the issue that the length of private namespaces are mis-calculated](https://github.com/apolloconfig/apollo/pull/5078)
* [Fix the issue that the length of private namespaces are miscalculated](https://github.com/apolloconfig/apollo/pull/5078)

@nobodyiam nobodyiam merged commit 3d14e6f into apolloconfig:master Apr 27, 2024
9 of 10 checks passed
@nobodyiam nobodyiam deleted the sync-portal-server-config branch April 27, 2024 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant