-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to stabilize flimsy tests #266
Conversation
size-limit report 📦
|
Job #91: Bundle Size — 1.01MiB (0%).Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
Current Job #91 |
Baseline Job #88 |
|
---|---|---|
Initial JS | 890.59KiB |
890.59KiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 0.04% |
0.04% |
Chunks | 24 |
24 |
Assets | 45 |
45 |
Modules | 512 |
512 |
Duplicate Modules | 30 |
30 |
Duplicate Code | 1.29% |
1.29% |
Packages | 29 |
29 |
Duplicate Packages | 1 |
1 |
Bundle size by type no changes
Current Job #91 |
Baseline Job #88 |
|
---|---|---|
JS | 1023.85KiB |
1023.85KiB |
Other | 5.99KiB |
5.99KiB |
View job #91 report View pr/test-changes branch activity View project dashboard
The infuriating thing is that these tests do not fail on localhost. |
But downgrading my local node to v20 does fail the unit tests... Bumping the node version to 21 for the unit tests. |
Logged as a node bug at nodejs/node#52325 and pinned the node version for now. |
These tests fail from time to time, e.g. in this run: https://github.com/apollographql/apollo-client-nextjs/actions/runs/8523111570/job/23344752684
Let's see if we get them more stable?