Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to stabilize flimsy tests #266

Merged
merged 3 commits into from
Apr 2, 2024
Merged

try to stabilize flimsy tests #266

merged 3 commits into from
Apr 2, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Apr 2, 2024

These tests fail from time to time, e.g. in this run: https://github.com/apollographql/apollo-client-nextjs/actions/runs/8523111570/job/23344752684

Let's see if we get them more stable?

@phryneas phryneas requested a review from a team as a code owner April 2, 2024 13:38
Copy link

github-actions bot commented Apr 2, 2024

size-limit report 📦

Path Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM) 7.79 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.41 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 6.25 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.12 KB (0%)
@apollo/client-react-streaming (SSR ESM) 1.72 KB (0%)
@apollo/client-react-streaming (RSC ESM) 1020 B (0%)
@apollo/client-react-streaming/manual-transport (Browser ESM) 6.43 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 6.32 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM) 8.4 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM) 8.3 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM) 839 B (0%)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 261 B (0%)

Copy link

relativeci bot commented Apr 2, 2024

Job #91: Bundle Size — 1.01MiB (0%).

a4e1984(current) vs b508a5a main#88(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  no changes
                 Current
Job #91
     Baseline
Job #88
No change  Initial JS 890.59KiB 890.59KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0.04% 0.04%
No change  Chunks 24 24
No change  Assets 45 45
No change  Modules 512 512
No change  Duplicate Modules 30 30
No change  Duplicate Code 1.29% 1.29%
No change  Packages 29 29
No change  Duplicate Packages 1 1
Bundle size by type  no changes
                 Current
Job #91
     Baseline
Job #88
Not changed  JS 1023.85KiB 1023.85KiB
Not changed  Other 5.99KiB 5.99KiB

View job #91 reportView pr/test-changes branch activityView project dashboard

@phryneas
Copy link
Member Author

phryneas commented Apr 2, 2024

The infuriating thing is that these tests do not fail on localhost.

@phryneas
Copy link
Member Author

phryneas commented Apr 2, 2024

But downgrading my local node to v20 does fail the unit tests... Bumping the node version to 21 for the unit tests.

@phryneas
Copy link
Member Author

phryneas commented Apr 2, 2024

Logged as a node bug at nodejs/node#52325 and pinned the node version for now.

@phryneas phryneas merged commit 9fc65d3 into main Apr 2, 2024
16 checks passed
@phryneas phryneas deleted the pr/test-changes branch April 2, 2024 14:25
@phryneas phryneas restored the pr/test-changes branch April 2, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant