Improve error message when computeKeyFieldsObject throws.

#6673 (comment)
apollographql · Aug 20, 2021 · 30857d7 · 30857d7
1 parent cd89150
commit 30857d7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/src/cache/inmemory/__tests__/entityStore.ts b/src/cache/inmemory/__tests__/entityStore.ts
@@ -1779,7 +1779,9 @@ describe('EntityStore', () => {
         expect(cache.identify(ABCs)).toBeUndefined();
         expect(consoleWarnSpy).toHaveBeenCalledTimes(1);
         expect(consoleWarnSpy).toHaveBeenCalledWith(
-          new Error("Missing field 'b' while computing key fields")
+          new Error(`Missing field 'b' while extracting keyFields from ${
+            JSON.stringify(ABCs)
+          }`),
         );
       } finally {
         consoleWarnSpy.mockRestore();

diff --git a/src/cache/inmemory/__tests__/policies.ts b/src/cache/inmemory/__tests__/policies.ts
@@ -346,7 +346,11 @@ describe("type policies", function () {
           book: theInformationBookData,
         },
       });
-    }).toThrowError("Missing field 'year' while computing key fields");
+    }).toThrowError(
+      `Missing field 'year' while extracting keyFields from ${JSON.stringify(
+        theInformationBookData
+      )}`,
+    );
   });
 
   it("does not clobber previous keyFields with undefined", function () {

diff --git a/src/cache/inmemory/policies.ts b/src/cache/inmemory/policies.ts
@@ -1118,7 +1118,9 @@ function computeKeyFieldsObject(
       const responseKey = aliases && aliases[s] || s;
       invariant(
         hasOwn.call(response, responseKey),
-        `Missing field '${responseKey}' while computing key fields`,
+        `Missing field '${responseKey}' while extracting keyFields from ${
+          JSON.stringify(response)
+        }`,
       );
       keyObj[lastActualKey = s] = response[lastResponseKey = responseKey];
     }