Skip to content

Commit

Permalink
Ensure transporters are using isomorphic-fetch instead of browser onl…
Browse files Browse the repository at this point in the history
…y whatwg-fetch
  • Loading branch information
guilhermeblanco committed Dec 9, 2016
1 parent 4a7e402 commit 7dd8535
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ David Alan Hjelle <dahjelle+github.com@thehjellejar.com>
David Glasser <glasser@meteor.com>
Dhaivat Pandya <dhaivat@meteor.com>
Dhaivat Pandya <dhaivatpandya@gmail.com>
Guilherme Blanco <guilhermeblanco@hotmail.com>
Google Inc.
Ian Grayson <ian133@gmail.com>
Ian MacLeod <ian@nevir.net>
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Expect active development and potentially significant breaking changes in the `0.x` track. We'll try to be diligent about releasing a `1.0` version in a timely fashion (ideally within 3 to 6 months), to signal the start of a more stable API.

### vNEXT
- Ensure transporters are using `isomorphic-fetch` instead of `whatwg-fetch` for universal compatibility [PR #1018](https://github.com/apollostack/apollo-client/pull/1018)

### 0.5.13
- Replace usages of `Object.assign` with lodash's assign function [PR #1009](https://github.com/apollostack/apollo-client/pull/1009)
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"lodash": "^4.17.2",
"redux": "^3.3.1",
"symbol-observable": "^1.0.2",
"whatwg-fetch": "^2.0.0"
"isomorphic-fetch": "^2.2.1"
},
"devDependencies": {
"@types/chai-as-promised": "0.0.28",
Expand All @@ -56,7 +56,6 @@
"grunt": "1.0.1",
"grunt-tslint": "3.3.0",
"gzip-size": "^3.0.0",
"isomorphic-fetch": "^2.2.1",
"istanbul": "^0.4.5",
"lodash": "^4.17.1",
"minimist": "^1.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/transport/batchedNetworkInterface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {
GraphQLResult,
} from 'graphql';

import 'whatwg-fetch';
import 'isomorphic-fetch';

import assign = require('lodash/assign');
import isNumber = require('lodash/isNumber');
Expand Down
2 changes: 1 addition & 1 deletion src/transport/networkInterface.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import isString = require('lodash/isString');
import assign = require('lodash/assign');
import mapValues = require('lodash/mapValues');
import 'whatwg-fetch';
import 'isomorphic-fetch';

import {
GraphQLResult,
Expand Down
2 changes: 1 addition & 1 deletion test/batchedNetworkInterface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { AfterwareInterface } from '../src/transport/afterware';

import { GraphQLResult } from 'graphql';

import 'whatwg-fetch';
import 'isomorphic-fetch';

import gql from 'graphql-tag';

Expand Down
6 changes: 3 additions & 3 deletions test/mocks/mockFetch.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'whatwg-fetch';
import 'isomorphic-fetch';

// This is an implementation of a mocked window.fetch implementation similar in
// structure to the MockedNetworkInterface.
// This is an implementation of a mocked window.fetch/global.fetch implementation
// similar in structure to the MockedNetworkInterface.

export interface MockedIResponse {
json(): Promise<JSON>;
Expand Down

0 comments on commit 7dd8535

Please sign in to comment.