Prefer import * as for imports whose types are re-exported (#7742)

Fixes #7741.

Using `import React from 'react'` causes issues when the import makes
its way into the d.ts file. Users without `esModuleInterop: true` or
`allowSyntheticDefaultImports: true` (or `skipLibCheck: true`) in
their tsconfig files will get errors from typescript about not being
able to default-import using that syntax.

This PR fixes the specific imports that would cause issues due to
their types being re-exported in `@apollo/client`'s types.

CHANGELOG.md

@@ -26,6 +26,9 @@ TBD
 - Allow `merge: true` field policy to merge `Reference` objects with non-normalized objects, and vice-versa. <br/>
   [@benjamn](https://github.com/benjamn) in [#7778](https://github.com/apollographql/apollo-client/pull/7778)
 
+- Prefer `import * as namepace ...` for imports whose types are re-exported (and thus may appear in `.d.ts` files). <br/>
+  [@devrelm](https://github.com/devrelm) in [#7742](https://github.com/apollographql/apollo-client/pull/7742)
+
 ### Documentation
 TBD
 

src/link/persisted-queries/__tests__/react.tsx

@@ -1,5 +1,5 @@
-import React from 'react';
-import ReactDOM from 'react-dom/server';
+import * as React from 'react';
+import * as ReactDOM from 'react-dom/server';
 import gql from 'graphql-tag';
 import { print } from 'graphql';
 import { sha256 } from 'crypto-hash';

src/react/components/Mutation.tsx

@@ -1,4 +1,4 @@
-import PropTypes from 'prop-types';
+import * as PropTypes from 'prop-types';
 
 import { OperationVariables } from '../../core';
 import { MutationComponentOptions } from './types';

src/react/components/Query.tsx

@@ -1,4 +1,4 @@
-import PropTypes from 'prop-types';
+import * as PropTypes from 'prop-types';
 
 import { OperationVariables } from '../../core';
 import { QueryComponentOptions } from './types';

src/react/components/Subscription.tsx

@@ -1,4 +1,4 @@
-import PropTypes from 'prop-types';
+import * as PropTypes from 'prop-types';
 
 import { OperationVariables } from '../../core';
 import { SubscriptionComponentOptions } from './types';

src/react/context/ApolloConsumer.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { invariant } from 'ts-invariant';
 
 import { ApolloClient } from '../../core';

src/react/context/ApolloContext.ts

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { ApolloClient } from '../../core';
 import { canUseWeakMap } from '../../utilities';
 

src/react/context/ApolloProvider.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { invariant } from 'ts-invariant';
 
 import { ApolloClient } from '../../core';

src/react/hoc/hoc-utils.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { invariant } from 'ts-invariant';
 import { OperationVariables } from '../../core';
 import { IDocumentDefinition } from '../parser';

src/react/hoc/mutation-hoc.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { DocumentNode } from 'graphql';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 

src/react/hoc/query-hoc.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { DocumentNode } from 'graphql';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 

src/react/hoc/subscription-hoc.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { DocumentNode } from 'graphql';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 

src/react/hoc/withApollo.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 import { invariant } from 'ts-invariant';
 

src/react/hooks/useApolloClient.ts

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { invariant } from 'ts-invariant';
 
 import { ApolloClient } from '../../core';

src/react/ssr/getDataFromTree.ts

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 import { getApolloContext } from '../context';
 import { RenderPromises } from './RenderPromises';
 

src/utilities/testing/mocking/MockedProvider.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import * as React from 'react';
 
 import { ApolloClient, DefaultOptions } from '../../../core';
 import { InMemoryCache as Cache } from '../../../cache';