Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

../../tsconfig.base does not exist #3374

Closed
chj-damon opened this issue Apr 27, 2018 · 12 comments
Closed

../../tsconfig.base does not exist #3374

chj-damon opened this issue Apr 27, 2018 · 12 comments
Assignees
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. 🐞 bug ✔ confirmed 🙏 help-wanted

Comments

@chj-damon
Copy link

there is a tsconfig.json file in apollo-cache dependency, which looks like this:

{
  "extends": "../../tsconfig.base",
  "compilerOptions": {
    "rootDir": "./src",
    "outDir": "lib",
    "lib": ["es6", "dom", "es2017.object"]
  },
  "include": ["src/**/*.ts"],
  "exclude": ["src/**/__tests__/*.ts"]
}

But tsconfig.base does not exist in my project. So What tsconfig.base should be?

@malimccalla
Copy link

Having the same issue here from apollo-cache-inmemory

@hwillson
Copy link
Member

"../../tsconfig.base" points to the tsconfig.base.json file in the root of the apollo-client project (the .json extension is optional when using extends). Thanks!

@Slessi
Copy link

Slessi commented May 22, 2018

@hwillson That much is clear, but the actual file does not exist when the library is included inside node_modules/

@hwillson
Copy link
Member

Thanks for the clarification @Slessi. The file isn't included when bundling intentionally. Is this causing a problem somewhere/somehow?

@Slessi
Copy link

Slessi commented May 23, 2018

@hwillson to be honest for a while VS Code kept annoyingly pointing it out to me as an error but now that I want to show it to you, it seems to not care anymore ¯\_(ツ)_/¯

@xuo
Copy link

xuo commented May 27, 2018

Same issue here, attached a screenshot. Prevented it from showing up by adding file excludes in VSCode.

tsconfig base does not exist-vscode

@bharathkuppala
Copy link

how can we overcome this error.Please do provide your solutions or suggestions

@hwillson hwillson reopened this Jun 5, 2018
@hwillson hwillson added 🐞 bug 🙏 help-wanted 📚 good-first-issue Issues that are suitable for first-time contributors. ✔ confirmed labels Jun 14, 2018
@larsfoll
Copy link

Same issue with multiple apollo packages

apollo-link-context, apollo-link-error, apollo-link-http and apollo-link-http-common

@gihrig
Copy link

gihrig commented Jun 20, 2018

Yeah, same here (apollo-cache-inmemory v1.2.4)

  1. Seems odd that this module is extending a userland file.
  2. Is everyone here using VS Code? (I am v1.24.1). Why is VS Code error checking node_modules? Default User Setting includes
    "files.watcherExclude": {..."**/node_modules/**": true}
    , is this a VS Code bug?
  3. I silenced the error by creating the expected tsconfig.base in my project root. I placed an empty pair of braces in that file {}

@snnsnn
Copy link

snnsnn commented Jul 3, 2018

In VS Code, If you are getting the error after package install or setting changes, just reload your workspace or folder.

@saostad
Copy link

saostad commented Aug 2, 2018

Same Error Here:

    "apollo-cache-inmemory": "^1.2.6",
    "apollo-client": "^2.3.7",
    "apollo-link": "^1.2.2",
    "apollo-link-context": "^1.0.8",
    "apollo-link-error": "^1.1.0",
    "apollo-link-http": "^1.5.4",
    "apollo-link-state": "^0.4.1",
    "apollo-upload-client": "^8.1.0",
    "typescript": "^3.0.1"

@hwillson hwillson self-assigned this Aug 10, 2018
hwillson added a commit that referenced this issue Aug 17, 2018
Lerna doesn't use the top level .npmignore when it publishes
each sub-package, so let's replicate each .npmignore (and adjust
as needed) to make sure it's used when publishing.

Fixes #3374.
@hwillson
Copy link
Member

Let's just get the tsconfig.json's out of those published packages altogether. They shouldn't be there. #3828 will address this. Thanks!

hwillson added a commit that referenced this issue Aug 17, 2018
* Move .npmignore into each package

Lerna doesn't use the top level .npmignore when it publishes
each sub-package, so let's replicate each .npmignore (and adjust
as needed) to make sure it's used when publishing.

Fixes #3374.

* Changelog update
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. 🐞 bug ✔ confirmed 🙏 help-wanted
Projects
None yet
Development

No branches or pull requests

10 participants