Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation recipes/static-typing.md#typing-the-higher-order-components unclear in example #3461

Closed
stevenqzhang opened this issue May 15, 2018 · 1 comment

Comments

@stevenqzhang
Copy link

Intended outcome:
Reading the code in https://github.com/apollographql/apollo-client/blob/master/docs/source/recipes/static-typing.md#typing-the-higher-order-components should be clear

Actual outcome:

The comment // note the first parameter is empty here, we will exaplain that below (near bottom of the code block sample. indicates that the empty first parameter will be explained, but it's not actually clear to me where that explanation is. I expect some sort of explanation that ends with ...and that is why the first parameter in the code snippet above is an empty object

How to reproduce the issue:

n/a

Version

  • apollo-client@
@ghost ghost added the 📝 documentation label May 15, 2018
hwillson added a commit that referenced this issue Jun 10, 2018
The initial comment was a bit misleading.

Fixes #3461.
@hwillson
Copy link
Member

Thanks for pointing this out @stevenqzhang - this has been fixed in #3567.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants