Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Release 3.7) Rename useFragment -> useFragment_experimental #10075

Merged
merged 2 commits into from
Sep 7, 2022
Merged

(Release 3.7) Rename useFragment -> useFragment_experimental #10075

merged 2 commits into from
Sep 7, 2022

Conversation

MrDoomBringer
Copy link
Contributor

Per #10074
We'll use the name useFragment_experimental to clarify that the useFragment hook implementation might change after the initial beta release

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@MrDoomBringer MrDoomBringer added this to the Release 3.7 milestone Sep 6, 2022
benjamn
benjamn approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks @MrDoomBringer!

@benjamn benjamn merged commit d2c858a into apollographql:release-3.7 Sep 7, 2022
@MrDoomBringer MrDoomBringer mentioned this pull request Sep 8, 2022
Closed
@MrDoomBringer MrDoomBringer self-assigned this Sep 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees

@MrDoomBringer MrDoomBringer

Labels
None yet
Projects
None yet
Milestone
Release 3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@MrDoomBringer @benjamn