-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve context types #10402
Improve context types #10402
Conversation
Hugodby
commented
Jan 4, 2023
- Allow declaration merging for DefaultContext
- Use DefaultContext instead of any
- Tests: Linked the package manually
- Issues: Proper types for link context #9249 Support generic context type on ContextSetter and setContext #8902
@Hugodby: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🦋 Changeset detectedLatest commit: 75a928d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @Hugodby 👋 ! Thanks so much for this contribution! Would you be willing to add a changeset to this PR? You can do so by running |
Hello @jerelmiller , thank you for your message. I just added the changeset. |
Hey @Hugodby thanks for your patience! We had some intermittent test failures on We will get this PR tended to soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Hugodby!