chore: adds tests for WebSockets error cases and handles Event sent on error #10586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63f00c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benjamn
reviewed
Feb 21, 2023
|
Is there something I can do to help here ? I would really like this pr (or even better, #10411 ) to be merged 🙂 |
3 tasks
alessbell
force-pushed
the
issue-10394-websocket-errors
branch
from
42fb2d6 to
7b13cde
Compare
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alessbell
commented
Mar 29, 2023
2 tasks
alessbell
commented
Mar 29, 2023
alessbell
force-pushed
the
issue-10394-websocket-errors
branch
from
afc1826 to
bc5c766
Compare
alessbell
changed the title
undefined message
benjamn
approved these changes
Mar 31, 2023
jerelmiller
approved these changes
Mar 31, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10394.
Adds tests and prevents
undefinederror message after a websocket connection is closed when network connection is lost.Checklist: