Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Troubleshooting section to React Native docs #10723

Merged

Conversation

alessbell
Copy link
Contributor

@alessbell alessbell commented Apr 4, 2023

Inspired by #10719.

Adds a Troubleshooting section to the React Native docs with an initial bullet point about the Metro bundler's default configuration with respect to .cjs/.mjs files extensions.

URL to preview page: https://deploy-preview-10723--apollo-client-docs.netlify.app/integrations/react-native

CleanShot 2023-04-04 at 16 32 35

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

⚠️ No Changeset found

Latest commit: 292016b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 292016b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/642d7ef8fc19e30008babc71
😎 Deploy Preview https://deploy-preview-10723--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


## Troubleshooting

Here are a few common React Native problems and solutions.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borrowed this Troubleshooting format from the apollo-link-rest page. Checking to see if there are any other points to call out here from past RN-related issues, but if there's only one I'll remove this line.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Feel free to take or leave my suggestions. The troubleshooting section is super helpful though.

docs/source/integrations/react-native.md Outdated Show resolved Hide resolved
docs/source/integrations/react-native.md Outdated Show resolved Hide resolved
@alessbell alessbell merged commit 439eac0 into main Apr 5, 2023
@alessbell alessbell deleted the issue-10719-improve-react-native-docs-cjs-file-resolution branch April 5, 2023 14:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants