Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support returnPartialData and refetchWritePolicy in useBackgroundQuery #10960

Conversation

alessbell
Copy link
Contributor

@alessbell alessbell commented Jun 7, 2023

Closes #10893 and stacks on top of #10951 (merged).

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@alessbell alessbell requested a review from jerelmiller June 7, 2023 20:56
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: c12e24c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Really great to get the types dialed in. Thanks for pushing this forward!

src/utilities/types/DeepPartial.ts Outdated Show resolved Hide resolved
src/react/hooks/useBackgroundQuery.ts Outdated Show resolved Hide resolved
src/react/hooks/__tests__/useBackgroundQuery.test.tsx Outdated Show resolved Hide resolved
src/react/hooks/__tests__/useBackgroundQuery.test.tsx Outdated Show resolved Hide resolved
Base automatically changed from issue-10878-improve-useBackgroundQuery-types to release-3.8 June 9, 2023 17:26
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 36.85 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.38 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.56 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.3 KB (0%)
import { useQuery } from "dist/react/index.js" 4.33 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.65 KB (0%)
import { useMutation } from "dist/react/index.js" 2.56 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.31 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 3.71 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 3.78 KB (0%)
import { useReadQuery } from "dist/react/index.js" 2.48 KB (0%)
import { useFragment } from "dist/react/index.js" 2.12 KB (0%)

@alessbell alessbell force-pushed the issue-10893-support-returnPartialData-refetchWritePolicy-in-uBQ branch from 72ab861 to 7bcb22b Compare June 26, 2023 18:54
@alessbell alessbell marked this pull request as ready for review June 28, 2023 01:36
@alessbell alessbell requested a review from jerelmiller June 28, 2023 01:36
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great to have this in there!


rerender({ variables: { id: '2' } });

expect(await screen.findByText('2 - Black Widow')).toBeInTheDocument();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 I love this so much. Sure is cleaner than await waitFor

@alessbell alessbell merged commit ee407ef into release-3.8 Jun 28, 2023
@alessbell alessbell deleted the issue-10893-support-returnPartialData-refetchWritePolicy-in-uBQ branch June 28, 2023 11:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.8 beta] Support returnPartialData and refetchWritePolicy in useBackgroundQuery
2 participants