QueryReference: check for resolve/reject

[phryneas]

This came up in this Discord message

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

[changeset-bot]

🦋 Changeset detected

Latest commit: fcda4a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[phryneas]

apollo-client/src/react/cache/QueryReference.ts

Lines 73 to 78 in 816a7b6

	if (!this.promise) {
	this.promise = new Promise((resolve, reject) => {
	this.resolve = resolve;
	this.reject = reject;
	});
	}

This code path is not always reached, so this.resolve and this.reject might be undefined.

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	36.79 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	43.22 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	32.49 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.3 KB (0%)
import { useQuery } from "dist/react/index.js"	4.34 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	4.66 KB (0%)
import { useMutation } from "dist/react/index.js"	2.57 KB (0%)
import { useSubscription } from "dist/react/index.js"	2.34 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	3.71 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	3 KB (0%)
import { useReadQuery } from "dist/react/index.js"	1.81 KB (0%)
import { useFragment } from "dist/react/index.js"	2.12 KB (0%)

[jerelmiller]

The change looks great, but would love to see a test to ensure we don't introduce regressions later. Thanks!

[jerelmiller]

Would you mind writing a test for this? I'll be refactoring this a bit and want to make sure I don't introduce a regression. According to the discord message, it looks like subsequent fetches after a cache hit will cause this. Would love to have a test that shows this as fixed. Thanks!

[phryneas]

I can try. I have to admit I didn't have enough context on how to potentially trigger this.

[phryneas]

/release:pr

[github-actions]

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10999-20230622083105.

[jerelmiller]

🎉