-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print
: use WeakCache
instead of WeakMap
#11367
Conversation
🦋 Changeset detectedLatest commit: 3b60d3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/release:pr |
size-limit report 📦
|
A new release has been made for this PR. You can install it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I only had one small question about code style. Thanks for updating this!
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Using a
WeakCache
instead of aWeakMap
will allow us to set a maximum cache size.Checklist: