parse function: improve memory management

.api-reports/api-report-react.md

@@ -1397,6 +1397,12 @@ type OperationVariables = Record<string, any>;
 // @public (undocumented)
 export function parser(document: DocumentNode): IDocumentDefinition;
 
+// @public (undocumented)
+export namespace parser {
+    var // (undocumented)
+    resetCache: () => void;
+}
+
 // @public (undocumented)
 type Path = ReadonlyArray<string | number>;
 

.api-reports/api-report-react_parser.md

@@ -34,6 +34,12 @@ export function operationName(type: DocumentType_2): string;
 // @public (undocumented)
 export function parser(document: DocumentNode): IDocumentDefinition;
 
+// @public (undocumented)
+export namespace parser {
+    var // (undocumented)
+    resetCache: () => void;
+}
+
 // @public (undocumented)
 export function verifyDocumentType(document: DocumentNode, type: DocumentType_2): void;
 

.api-reports/api-report.md

@@ -1892,6 +1892,12 @@ export function parseAndCheckHttpResponse(operations: Operation | Operation[]):
 // @public (undocumented)
 export function parser(document: DocumentNode): IDocumentDefinition;
 
+// @public (undocumented)
+export namespace parser {
+    var // (undocumented)
+    resetCache: () => void;
+}
+
 // @public (undocumented)
 export type Path = ReadonlyArray<string | number>;
 

.changeset/cold-llamas-turn.md

@@ -0,0 +1,8 @@
+---
+"@apollo/client": patch
+---
+
+`parse` function: improve memory management
+* use LRU `WeakCache` instead of `Map` to keep a limited number of parsed results
+* cache is initiated lazily, only when needed
+* expose `parse.resetCache()` method

.changeset/polite-avocados-warn.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+`print`: use `WeakCache` instead of `WeakMap`

.size-limit.cjs

@@ -35,6 +35,7 @@ const checks = [
       "react",
       "react-dom",
       "@graphql-typed-document-node/core",
+      "@wry/caches",
       "@wry/context",
       "@wry/equality",
       "@wry/trie",

.size-limits.json

@@ -1,4 +1,4 @@
 {
-  "dist/apollo-client.min.cjs": 38164,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32188
+  "dist/apollo-client.min.cjs": 38201,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32206
 }

package.json

@@ -90,6 +90,7 @@
   },
   "dependencies": {
     "@graphql-typed-document-node/core": "^3.1.1",
+    "@wry/caches": "^1.0.0",
     "@wry/context": "^0.7.3",
     "@wry/equality": "^0.5.6",
     "@wry/trie": "^0.4.3",

src/react/parser/index.ts

@@ -1,3 +1,4 @@
+import { WeakCache } from "@wry/caches";
 import { invariant } from "../../utilities/globals/index.js";
 
 import type {
@@ -19,7 +20,16 @@ export interface IDocumentDefinition {
   variables: ReadonlyArray<VariableDefinitionNode>;
 }
 
-const cache = new Map();
+let cache:
+  | undefined
+  | WeakCache<
+      DocumentNode,
+      {
+        name: string;
+        type: DocumentType;
+        variables: readonly VariableDefinitionNode[];
+      }
+    >;
 
 export function operationName(type: DocumentType) {
   let name;
@@ -39,6 +49,10 @@ export function operationName(type: DocumentType) {
 
 // This parser is mostly used to safety check incoming documents.
 export function parser(document: DocumentNode): IDocumentDefinition {
+  if (!cache) {
+    cache =
+      new WeakCache(/** TODO: decide on a maximum size (will do all max sizes in a combined separate PR) */);
+  }
   const cached = cache.get(document);
   if (cached) return cached;
 
@@ -131,6 +145,10 @@ export function parser(document: DocumentNode): IDocumentDefinition {
   return payload;
 }
 
+parser.resetCache = () => {
+  cache = undefined;
+};
+
 export function verifyDocumentType(document: DocumentNode, type: DocumentType) {
   const operation = parser(document);
   const requiredOperationName = operationName(type);

src/utilities/graphql/print.ts

@@ -1,23 +1,23 @@
 import type { ASTNode } from "graphql";
 import { print as origPrint } from "graphql";
-import { canUseWeakMap } from "../common/canUse.js";
+import { WeakCache } from "@wry/caches";
 
-let printCache: undefined | WeakMap<ASTNode, string>;
-// further TODO: replace with `optimism` with a `WeakCache` once those are available
+let printCache!: WeakCache<ASTNode, string>;
 export const print = Object.assign(
   (ast: ASTNode) => {
-    let result;
-    result = printCache?.get(ast);
+    let result = printCache.get(ast);
 
     if (!result) {
-      result = origPrint(ast);
-      printCache?.set(ast, result);
+      printCache.set(ast, (result = origPrint(ast)));
     }
     return result;
   },
   {
     reset() {
-      printCache = canUseWeakMap ? new WeakMap() : undefined;
+      printCache = new WeakCache<
+        ASTNode,
+        string
+      >(/** TODO: decide on a maximum size (will do all max sizes in a combined separate PR) */);
     },
   }
 );