Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new React APIs in code - Part 2 of 2 #11523

Merged
merged 28 commits into from
Jan 26, 2024

Conversation

jerelmiller
Copy link
Member

This is a continuation of #11512 that adds the necessary code-level documentation that will be used to document the new APIs in our editors and docs.

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: 66b958e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 25, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.24 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.04 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.59 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.96 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.89 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.29 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.76 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.4 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.97 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.04 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.98 KB (0%)
import { useFragment } from "dist/react/index.js" 2.19 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.13 KB (0%)

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 00e075c
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65b2a8e189c4480008216475
😎 Deploy Preview https://deploy-preview-11523--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 66b958e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65b42095f9a4a80008a53586
😎 Deploy Preview https://deploy-preview-11523--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (assuming you don't want to cover additional apis in this PR) :)

@github-actions github-actions bot added the auto-cleanup 🤖 label Jan 26, 2024
@jerelmiller jerelmiller force-pushed the jerel/document-new-hooks-in-code branch from d320111 to a80245e Compare January 26, 2024 19:01
@jerelmiller jerelmiller force-pushed the jerel/document-new-hooks-in-code branch from ef376c9 to 66b958e Compare January 26, 2024 21:13
@jerelmiller jerelmiller marked this pull request as ready for review January 26, 2024 21:15
@jerelmiller jerelmiller requested a review from a team as a code owner January 26, 2024 21:15
@jerelmiller jerelmiller merged commit 2964a13 into release-3.9 Jan 26, 2024
33 checks passed
@jerelmiller jerelmiller deleted the jerel/document-new-hooks-in-code branch January 26, 2024 23:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants