Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also wrap createQueryPreloader #11719

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Conversation

phryneas
Copy link
Member

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 0214111

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas
Copy link
Member Author

/release:pr

Copy link
Contributor

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11719-20240322142549

Copy link
Contributor

github-actions bot commented Mar 22, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 39.09 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.8 KB (+0.07% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.36 KB (+0.08% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.27 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.13 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.23 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.31 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.79 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.77 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.91 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.49 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.15 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.99 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.64 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.33 KB (0%)
import { useFragment } from "dist/react/index.js" 2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.27 KB (0%)

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 0214111
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668ce7e0dbe7c10008208790
😎 Deploy Preview https://deploy-preview-11719--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller
Copy link
Member

@phryneas is this something you want to move forward with? If so, let's get it in 3.11

@phryneas
Copy link
Member Author

phryneas commented Jul 8, 2024

Yeah. We currently don't need it, but it will probably get necessary to support query preloading in loader-based frameworks, so let's get it in.

@phryneas phryneas changed the base branch from main to release-3.11 July 8, 2024 08:36
@phryneas phryneas added the auto-cleanup 🤖 label Jul 8, 2024
@phryneas phryneas marked this pull request as ready for review July 8, 2024 08:37
@phryneas phryneas added this to the 3.11.0 milestone Jul 8, 2024
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me! Had a question about the changes for package.json, but I think that is resolved by merging the latest release-3.11 into this branch.

package.json Outdated
@@ -108,18 +108,18 @@
},
"devDependencies": {
"@arethetypeswrong/cli": "0.15.3",
"@babel/parser": "7.24.5",
"@babel/parser": "7.24.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these changes a result of merging main into this branch? I just merged main into the release-3.11 so perhaps just pull that in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clean that up before merging, thanks for pointing it out :)

@phryneas phryneas merged commit 09a6677 into release-3.11 Jul 9, 2024
35 of 36 checks passed
@phryneas phryneas deleted the pr/wrap-createQueryPreloader branch July 9, 2024 07:39
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants