-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
also wrap createQueryPreloader #11719
Conversation
🦋 Changeset detectedLatest commit: 0214111 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/release:pr |
A new release has been made for this PR. You can install it with:
|
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@phryneas is this something you want to move forward with? If so, let's get it in 3.11 |
Yeah. We currently don't need it, but it will probably get necessary to support query preloading in loader-based frameworks, so let's get it in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me! Had a question about the changes for package.json
, but I think that is resolved by merging the latest release-3.11
into this branch.
package.json
Outdated
@@ -108,18 +108,18 @@ | |||
}, | |||
"devDependencies": { | |||
"@arethetypeswrong/cli": "0.15.3", | |||
"@babel/parser": "7.24.5", | |||
"@babel/parser": "7.24.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these changes a result of merging main
into this branch? I just merged main
into the release-3.11
so perhaps just pull that in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll clean that up before merging, thanks for pointing it out :)
See apollographql/apollo-client-nextjs#248