-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept min and max delay in createSchemaFetch
options
#11774
Accept min and max delay in createSchemaFetch
options
#11774
Conversation
🦋 Changeset detectedLatest commit: d8891ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
createSchemaFetch
optionscreateSchemaFetch
options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I LOVE this addition. I had a few suggestions as well to see if we can make a couple more incremental improvements.
@alessbell thanks for the callout, that was a profiler bug - sorry for the frustration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick in the test, otherwise approved :)
…hub.com:apollographql/apollo-client into issue-11748-min-max-createSchemaFetch-threshold
Closes #11748.