Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoCleanedCache: only schedule batched cache cleanup if the cache is full #11792

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

phryneas
Copy link
Member

Fixes #11790

This prevents timeouts from being set when they are not necessary.

This should probably go into a 3.10.1

… full

Fixes #11790

This prevents timeouts from being set when they are not necessary.
Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 992a2a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas
Copy link
Member Author

/release:pr

Copy link
Contributor

github-actions bot commented Apr 19, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.62 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.5 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.05 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.17 KB (+0.06% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.06 KB (+0.07% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.28 KB (+0.34% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.37 KB (+0.45% 🔺)
import { useLazyQuery } from "dist/react/index.js" 5.52 KB (+0.32% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production) 4.59 KB (+0.39% 🔺)
import { useMutation } from "dist/react/index.js" 3.52 KB (+0.48% 🔺)
import { useMutation } from "dist/react/index.js" (production) 2.74 KB (+0.54% 🔺)
import { useSubscription } from "dist/react/index.js" 3.21 KB (+0.62% 🔺)
import { useSubscription } from "dist/react/index.js" (production) 2.4 KB (+0.91% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" 5.46 KB (+0.4% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.12 KB (+0.5% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" 4.94 KB (+0.48% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.59 KB (+0.58% 🔺)
import { useLoadableQuery } from "dist/react/index.js" 5.05 KB (+0.41% 🔺)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.71 KB (+0.53% 🔺)
import { useReadQuery } from "dist/react/index.js" 3.31 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.25 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

Copy link
Contributor

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11792-20240419093048

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 992a2a3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/662947b6ea1b4f0008e6600b
😎 Deploy Preview https://deploy-preview-11792--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas
Copy link
Member Author

Tests are failing because playwright binaries can't be downloaded from archive.ubuntu.com right now.
I'd assume that will pick up in a few hours.

@phryneas phryneas marked this pull request as ready for review April 19, 2024 11:48
@phryneas
Copy link
Member Author

Tests did run again and are green.

Copy link
Member

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice optimization 🚀

@github-actions github-actions bot added the auto-cleanup 🤖 label Apr 19, 2024
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢 it

Base automatically changed from release-3.10 to main April 24, 2024 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCleanedWeakCache causes failure when running tests in fakeAsync zone
3 participants