Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderPromises: use canonicalStringify to serialize data, use Trie #11799

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

phryneas
Copy link
Member

fixes #11798
This ensures that queries with variables of equal contents, but different order, will be handled the same way during renderToStringWithData SSR. It also replaces a hand-written Trie implementation with the Trie dependency.

fixes #11798
This ensures that queries with variables of equal contents, but different order, will be handled the same way during `renderToStringWithData` SSR.
It also replaces a hand-written Trie implementation with the `Trie` dependency.
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: c7767b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas
Copy link
Member Author

/release:pr

Copy link
Contributor

github-actions bot commented Apr 22, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.62 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.5 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.05 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.17 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.06 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.37 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.52 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.59 KB (0%)
import { useMutation } from "dist/react/index.js" 3.52 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.74 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.4 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.12 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.59 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.05 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.71 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.31 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.25 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

Copy link
Contributor

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11799-20240422143231

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit c7767b8
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66294d953b41ad00082fe2ce
😎 Deploy Preview https://deploy-preview-11799--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Had a suggestion about the changelog entry, but nothing major.

.changeset/early-pots-rule.md Outdated Show resolved Hide resolved
function makeDefaultQueryInfo(): QueryInfo {
return {
function makeQueryInfoTrie() {
// these Tries are very short-lived, so we don't need to worry about making it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 love these kinds of comments. Thanks for adding the helpful context.

@github-actions github-actions bot added the auto-cleanup 🤖 label Apr 22, 2024
@phryneas phryneas merged commit 1aca7ed into main Apr 24, 2024
33 checks passed
@phryneas phryneas deleted the pr/fix-11798 branch April 24, 2024 18:30
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useQuery fails to resolve ssr renderPromise due to JSON.stringify reordering
2 participants