-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RenderPromises
: use canonicalStringify
to serialize data, use Trie
#11799
Conversation
fixes #11798 This ensures that queries with variables of equal contents, but different order, will be handled the same way during `renderToStringWithData` SSR. It also replaces a hand-written Trie implementation with the `Trie` dependency.
🦋 Changeset detectedLatest commit: c7767b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/release:pr |
size-limit report 📦
|
A new release has been made for this PR. You can install it with:
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Had a suggestion about the changelog entry, but nothing major.
function makeDefaultQueryInfo(): QueryInfo { | ||
return { | ||
function makeQueryInfoTrie() { | ||
// these Tries are very short-lived, so we don't need to worry about making it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 love these kinds of comments. Thanks for adding the helpful context.
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
fixes #11798
This ensures that queries with variables of equal contents, but different order, will be handled the same way during
renderToStringWithData
SSR. It also replaces a hand-written Trie implementation with theTrie
dependency.