Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useSubscription: fix rules of React violations #11863

Merged
merged 14 commits into from
Jul 3, 2024
Merged

useSubscription: fix rules of React violations #11863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
987ff6d
Revert "Merge pull request #9707 from kazekyo/fix_usesubscription_in_…
phryneas May 17, 2024
03d89ea
essentially rewrite useSubscription
phryneas May 21, 2024
06db150
use `setResult` update method
phryneas May 21, 2024
71dc7aa
adjust tests
phryneas May 21, 2024
ac0d804
change observable during render; lazy initialization of subscription
phryneas May 21, 2024
4aa14cf
no more need for stable options, performance optimization
phryneas May 21, 2024
af260cf
changeset
phryneas May 21, 2024
e249bad
adjust documentation
phryneas May 22, 2024
297919f
review feedback
phryneas Jun 25, 2024
9f64d3f
Apply suggestions from code review
phryneas Jul 3, 2024
654d949
clarify comment
phryneas Jul 3, 2024
74fe836
Merge remote-tracking branch 'origin/release-3.11' into pr/rules-of-h…
phryneas Jul 3, 2024
1af05a6
update size-limits
phryneas Jul 3, 2024
33829ec
fix test
phryneas Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-suits-return.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@apollo/client": minor
---

Reimplement `useSubscription` to fix rules of React violations.
2 changes: 1 addition & 1 deletion .size-limits.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"dist/apollo-client.min.cjs": 39604,
"dist/apollo-client.min.cjs": 39619,
"import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32852
}
Loading
Loading