Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable API #119

Merged
merged 18 commits into from
Apr 18, 2016
Merged

Observable API #119

merged 18 commits into from
Apr 18, 2016

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Apr 16, 2016

Reconstruction of @martijnwalraven's PR #97, on top of current master.

TODO:

  • Add tests for refetch before first fetch returns
  • Add tests for requests arriving in the wrong order on refetch

@stubailo stubailo added this to the alpha milestone Apr 16, 2016
@stubailo
Copy link
Contributor Author

@martijnwalraven I think I've reconstructed your whole PR on top of the two other features I merged -- let me know if I missed anything, but it looks like all the tests pass now!

@jbaxleyiii
Copy link
Contributor

@stubailo
Copy link
Contributor Author

@jbaxleyiii that would be an awesome way to rebuild this functionality once it ships! I'm glad that observables and Redux are something that are going to be officially together soon :]

@stubailo
Copy link
Contributor Author

Rebased on master

@stubailo
Copy link
Contributor Author

Filed an issue about the Redux observable thing: #123

@stubailo stubailo merged commit c0e7d30 into master Apr 18, 2016
@stubailo stubailo deleted the observable branch April 19, 2016 02:12
jbaxleyiii pushed a commit that referenced this pull request Oct 17, 2017
jbaxleyiii pushed a commit that referenced this pull request Oct 18, 2017
Fix a typo in pagination examples
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants