-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watchFragment
: forward additional options to diffOptions
#11926
Conversation
🦋 Changeset detectedLatest commit: 9b4ead4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/release:pr |
A new release has been made for this PR. You can install it with:
|
size-limit report 📦
|
const query = this.getFragmentDoc(fragment, fragmentName); | ||
|
||
const diffOptions: Cache.DiffOptions<TData, TVars> = { | ||
...otherOptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fix the reported problem, forwarding just variables
is already enough, but it might be a good idea to forward all unspecified options. WDYT @alessbell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other one is canonizeResults
which is is deprecated and actually not used anywhere... I think we can remove it since it never did anything :/
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one note about canonizeResults
- there's no harm in spreading otherOptions
but we should probably remove that anyways. Otherwise LGTM! 🚀
fixes #11924