Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate experimental testing utilities #11930

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

jerelmiller
Copy link
Member

Closes #11929

Deprecates experimental testing utilities introduced in 3.10 in favor of graphql-testing-library.

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 3fa3eb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jerelmiller jerelmiller requested a review from alessbell July 5, 2024 21:52
Copy link
Contributor

github-actions bot commented Jul 5, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 39.24 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.97 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.5 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.34 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.2 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.23 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.31 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.79 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.41 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.49 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.15 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.99 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.64 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.33 KB (0%)
import { useFragment } from "dist/react/index.js" 2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.27 KB (0%)

@jerelmiller
Copy link
Member Author

@alessbell would love your thoughts here. Also, what would we like to do with the schema driven testing doc? Do we want to add a note to the top of that with a similar deprecation warning? Or should we rewrite that for 3.11 to switch over to graphql-testing-library?

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 17dd3bd
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66886b27d32c2e000820a8ce
😎 Deploy Preview https://deploy-preview-11930--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 3fa3eb6
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668d76c90a61700008891488
😎 Deploy Preview https://deploy-preview-11930--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller jerelmiller added this to the 3.11.0 milestone Jul 8, 2024
@@ -50,6 +50,8 @@ interface TestSchemaOptions {
* ```
* @since 3.9.0
* @alpha
* @deprecated `createTestSchema` is deprecated and will be removed in 3.12.0.
* Please migrate to [`graphql-testing-library`](https://github.com/apollographql/graphql-testing-library).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want the repo name here or the npm package name which is @apollo/graphql-testing-library. I have a slight preference for the latter but either works :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout! I agree, the package name seems more reasonable. I've updated it with 7b6c071. Thanks!

Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening this! Left one minor comment but this LGTM 🚀

@github-actions github-actions bot added the auto-cleanup 🤖 label Jul 9, 2024
@jerelmiller jerelmiller merged commit a768575 into release-3.11 Jul 9, 2024
42 checks passed
@jerelmiller jerelmiller deleted the jerel/deprecate-schema-test-utilities branch July 9, 2024 18:41
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants