Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimisticResponse function return type #11944

Conversation

sneyderdev
Copy link
Contributor

@sneyderdev sneyderdev commented Jul 10, 2024

Fixes #11945

This PR fixes returning the IGNORE sentinel object from optimisticResponse when inferring the result data of a generic TypedDocumentNode mutation.

@apollo-cla
Copy link

@sneyderdev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit ee4dff0
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6694d095a7f05e0008a53f28
😎 Deploy Preview https://deploy-preview-11944--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 2f4ee90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and thank you for the PR!
Could you please sign the Contributor License Agreement so we can get this in? :)

@sneyderdev
Copy link
Contributor Author

Good catch, and thank you for the PR! Could you please sign the Contributor License Agreement so we can get this in? :)

Oh, I just did it again but I'm not sure what's wrong.
I'm getting this confirmation message and the confirmation email doesn't have any extra steps. Am I missing anything?
image

@phryneas
Copy link
Member

Let me ask around internally :)

@abernix
Copy link
Member

abernix commented Jul 12, 2024

I'm getting this confirmation message and the confirmation email doesn't have any extra steps. Am I missing anything?

There are no additional steps in the email. The CLA status checks are passing now, so I think you're all good. I'll let the repository folks take care of merging this.

There is one failing status check, but not sure if it's load bearing:

❌ Clean up Prettier, Size-limit, and Api-Extractor / add_cleanup_label (pull_request_review) Failing after 10s

😄 Hope this helps!

@phryneas
Copy link
Member

Ah, it seems I missed that that is passing now - it wasn't earlier 😅

@phryneas phryneas changed the base branch from main to release-3.11 July 15, 2024 07:30
@phryneas phryneas requested a review from a team as a code owner July 15, 2024 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error returning IGNORE object when using a generic TypedDocumentNode mutation
4 participants