-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optimisticResponse
function return type
#11944
Fix optimisticResponse
function return type
#11944
Conversation
… generic TypedDocumentNode mutation
@sneyderdev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🦋 Changeset detectedLatest commit: 2f4ee90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, and thank you for the PR!
Could you please sign the Contributor License Agreement so we can get this in? :)
Let me ask around internally :) |
There are no additional steps in the email. The CLA status checks are passing now, so I think you're all good. I'll let the repository folks take care of merging this. There is one failing status check, but not sure if it's load bearing:
😄 Hope this helps! |
Ah, it seems I missed that that is passing now - it wasn't earlier 😅 |
Fixes #11945
This PR fixes returning the
IGNORE
sentinel object fromoptimisticResponse
when inferring the result data of a genericTypedDocumentNode
mutation.