Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type MutationResult.reset as an arrow function #12027

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

JavaScriptBach
Copy link
Contributor

Type Mutation.reset as an arrow function.

This function doesn't depend on this, so it can be safely passed around as value. Typing this as an arrow function makes it clear and plays nicer with https://typescript-eslint.io/rules/unbound-method/

@apollo-cla
Copy link

@JavaScriptBach: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit d9ab0d1
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66cc98d601565a0008c244eb
😎 Deploy Preview https://deploy-preview-12027--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 59bc64b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really good call, thank you for the PR!

@phryneas phryneas added the auto-cleanup 🤖 label Aug 26, 2024
@phryneas phryneas changed the title Fix type Type MutationResult.reset as an arrow function Aug 27, 2024
@phryneas phryneas merged commit eb3e21b into apollographql:main Aug 27, 2024
42 checks passed
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants