Remove unsupported client.query options
#12562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cc52d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
commit: |
Contributor
size-limit report 📦
|
jerelmiller
force-pushed
the
jerel/deprecate-some-query-opts
branch
from
c9c81a7 to
5b1e718
Compare
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jerelmiller
commented
Apr 16, 2025
| }); | ||
|
|
||
| describe("when notifyOnNetworkStatusChange is set", () => { | ||
| it("does not save the data to the cache on success", async () => { |
Member
Author
There was a problem hiding this comment.
These are identical to some tests above with the exception that notifyOnNetworkStatusChange was passed to client.query. With this option removed, these tests no longer made sense to keep around.
phryneas
approved these changes
Apr 17, 2025
Member
phryneas
left a comment
phryneas
left a comment
There was a problem hiding this comment.
Less undefined behaviour - always happy about that :)
| "to receive multiple results from the cache and the network, or consider " + | ||
| "using a different fetchPolicy, such as cache-first or network-only." | ||
| ); | ||
|
|
Member
There was a problem hiding this comment.
Do we want to consider wrapping all these invariants in __DEV__?
Member
Author
There was a problem hiding this comment.
Yes! I like that idea.
…rkStatusChange from QueryOptions
jerelmiller
force-pushed
the
jerel/deprecate-some-query-opts
branch
from
cbc105c to
dc62585
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pollIntervalandreturnPartialDatawere options supported by theQueryOptionstype used byclient.queryeven though these options threw at runtime. These have been removed in theQueryOptionstype in this PR.notifyOnNetworkStatusChangewas also an option that was supported, though its effects were not observable byclient.query. I've removed support for this and runtime will now throw if this is set.I've also removed support for the
standbyfetch policy forclient.query. This fetch policy made no sense since it doesn't fetch and just returns{ data: undefined }. An error will be thrown at runtime if this is set.