Do not broadcast queries if Apollo state has not changed and if the previousState actually has anything inside of it.

[abhiaiyer91]

TODO:

• Update CHANGELOG.md with your change
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass

[abhiaiyer91]

actually i need to deepequal

[stubailo]

Couldn't we just do === because of the immutable nature of the store? I feel like deepEqual-ing the entire store isn't necessary.

[abhiaiyer91]

You may be right! I was just thinking that the store state is essentially

{
   queries,
   mutations,
   data
}

if we do a straight up === will we know if things actually changed? I guess I should have tested that.

[stubailo]

Ohhhhh, wait you're right - I don't think we currently ensure that the old object is the same as the new one in our top-level reducer.

So for now let's do deepEqual and see what happens, we can optimize later. Maybe add a XXX comment or file a perf issue about it.

[abhiaiyer91]

Ill add a comment and update the change log later

[stubailo]

Btw we should probably add at least one test that checks that the observer doesn't fire if the result didn't change!

This is one of those things that is really easy to accidentally break.

[abhiaiyer91]

Will do.

[coveralls]

Coverage increased (+0.4%) to 93.053% when pulling 3f9a8a0 on StopTheDataMadness into 2ba9b95 on master.

[coveralls]

Coverage increased (+0.08%) to 93.053% when pulling 4f0c612 on StopTheDataMadness into df0edf6 on master.

[abhiaiyer91]

Yeeeeere

[stubailo]

How did this test get into this PR? Is this a new test or did it somehow get duplicated accidentally?

[abhiaiyer91]

WHOA DUPE

[stubailo]

Looks awesome! Just confused about that extra test that seems unrelated.

[stubailo]

LGTM

[stubailo]

Great contribution dude!