Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optimistic read of cache using client #2429

Merged
merged 7 commits into from
Aug 10, 2018

Conversation

jer-sen
Copy link
Contributor

@jer-sen jer-sen commented Oct 30, 2017

To fix this issue : #2222

Tests and doc should be updated...

@jbaxleyiii
Copy link
Contributor

@Jay1337 great start! Adding tests for this should be able to be done following the patterns here and here

Let me know if you have any questions!

@stale
Copy link

stale bot commented Nov 21, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Apollo Client!

@jer-sen
Copy link
Contributor Author

jer-sen commented Nov 21, 2017

Hey !

@jbaxleyiii
Copy link
Contributor

@Jay1337 are you able to finish this? Or do you need me to? I'd love to get this shipped!

@jer-sen
Copy link
Contributor Author

jer-sen commented Nov 21, 2017

Honestly I don't know when I will have time for that. If you can do it... I think it would take you far less time than what it would take me.

@jbaxleyiii
Copy link
Contributor

@Jay1337 no worries! Thank you so much for all that you have already done for the 2.0 line! It wouldn't be nearly what it is without your investigations and help! I'll happily pick this up and get it shipped!

@jbaxleyiii jbaxleyiii self-assigned this Nov 21, 2017
@jer-sen
Copy link
Contributor Author

jer-sen commented Nov 21, 2017

@jbaxleyiii Thanks :)

@jbaxleyiii
Copy link
Contributor

@Jay1337 I'm going to close this one down and open it back up when I have some time to bring it in!

@jbaxleyiii jbaxleyiii closed this Jan 29, 2018
@danielgreane
Copy link

Hey,
What other work was needed on this? Seems to be working
We have a few places in our codebase where we depend on optimistic fragment and query reads (for offline support), I've run this PR locally and seems to be working fine. Is it just regression that's blocking it from being merged?

@hwillson hwillson reopened this Aug 9, 2018
@hwillson hwillson assigned hwillson and unassigned jbaxleyiii Aug 9, 2018
@apollo-cla
Copy link

apollo-cla commented Aug 9, 2018

Warnings
⚠️

❗ Big PR

Generated by 🚫 dangerJS

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you work on this @Jay1337 - we're all set here. LGTM!

@hwillson hwillson merged commit def24a2 into apollographql:master Aug 10, 2018
@jer-sen
Copy link
Contributor Author

jer-sen commented Aug 13, 2018

@hwillson you're welcome !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants