Avoid needless hasOwnProperty check in deepFreeze. #3545
Merged
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "own" in
getOwnPropertyNames
ensures that all the names would pass thehasOwnProperty
test.Regarding this comment by @jamesreggio, I would much rather patch
apollo-utilities
than revert the use ofObject.create(null)
, since empty prototype-free objects never accidentally appear to have properties inherited fromObject.prototype
(a correctness concern), and lookups of missing properties are faster since there's no prototype chain. Far from being deficient,Object.create(null)
objects are what empty objects should always have been in JavaScript.